Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples do not work #154

Open
anuragsr opened this issue Jun 19, 2022 · 7 comments
Open

Examples do not work #154

anuragsr opened this issue Jun 19, 2022 · 7 comments

Comments

@anuragsr
Copy link

anuragsr commented Jun 19, 2022

The links given for examples do not work.. just a blank screen appears with the page title and GUI if applicable

@anuragsr
Copy link
Author

The Birds example seems to work

@microdee
Copy link

The Birds example seems to work

but the lines are not there, as on the screenshot either

@savejeff
Copy link

examples still do not work. console gives error:


Uncaught TypeError: g.getAttribute is not a function
    at MeshLine.setGeometry (THREE.MeshLine.js:81:26)
    at makeLine (main-graph.js:47:4)
    at createLines (main-graph.js:76:2)
    at init (main-graph.js:64:2)
    at main-graph.js:41:1

@002301
Copy link

002301 commented Nov 2, 2022

modify THREE.MeshLine.js:81 to
// this.setPoints(g.getAttribute("position").array, c);
if (g instanceof THREE.Geometry) {
this.setPoints(g.vertices, c);
} else if (g instanceof THREE.BufferGeometry) {
this.setPoints(g.getAttribute("position").array, c);
} else {
this.setPoints(g, c);
}

002301 pushed a commit to 002301/THREE.MeshLine that referenced this issue Nov 2, 2022
Solves issue Examples do not work spite#154
@savejeff
Copy link

savejeff commented Nov 2, 2022

Thx. would it be possible to update the Demos/Examples?
They currently still do not work

@drcmda drcmda mentioned this issue Dec 7, 2022
@ActuallyHappening
Copy link

Still doesn't work, exact error as above

@POKEZHANG
Copy link

modify THREE.MeshLine.js:81 to // this.setPoints(g.getAttribute("position").array, c); if (g instanceof THREE.Geometry) { this.setPoints(g.vertices, c); } else if (g instanceof THREE.BufferGeometry) { this.setPoints(g.getAttribute("position").array, c); } else { this.setPoints(g, c); }

ok,it's work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants