You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
collidingTime / regularTime must be <2L// speed must be in same order of magnitude
In absolute terms, the regularTime is about 3E6 (3ms) on a modern laptop. This time is sufficiently large to make the test mostly pass on a dedicated machine. However, on a shared environment such as a Travis-CI build, it frequently causes the build to fail.
Potential solutions:
easy: increase the number of keys by an order of magnitude
future-proof: don't assume a number of keys will give a large enough time, but rather incrementally deduce that number for a given system time and then run the test
The text was updated successfully, but these errors were encountered:
I think we should not put too much effort in these tests - let's first increase the number of keys (and/or be more lenient in the expectation) - if that's not enough I'd even be open to doing a couple of runs or removing the test wholesale.
The "not show bad performance characteristics when object keys' hashCodes collide" test in JsonParserSpec is flaky.
spray-json/src/test/scala/spray/json/JsonParserSpec.scala
Line 117 in 0b893f2
In absolute terms, the
regularTime
is about 3E6 (3ms) on a modern laptop. This time is sufficiently large to make the test mostly pass on a dedicated machine. However, on a shared environment such as a Travis-CI build, it frequently causes the build to fail.Potential solutions:
The text was updated successfully, but these errors were encountered: