i18n fallbacks should not be overridden

[kreba]

Thank you for your work on this valuable gem 🙏

We are translating our application to many locales and we want our default_locale to be :de-CH, but we still want to ultimately fall back to :en because this is Spree's master locale.

So we want to configure app.config.i18n.fallbacks = [:de, :en]

However, the initializer spree_i18n.environment sets app.config.i18n.fallbacks = true, thus replacing any previous fallback configuration.

spree_i18n/lib/spree_i18n/engine.rb

Line 19 in be00bcd

app.config.i18n.fallbacks = true

Please change this to app.config.i18n.fallbacks ||= true (note the ||=) so our application can configure its own fallbacks.

Possible workaround for now: Our application can configure the fallbacks in a config.after_initialize do ... end block. That seems to do the trick. But we can't be sure that spree_i18n's initialization works as intended if we do this.