Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

delete cannot be executed without a --rel argument. #15

Closed
nebhale opened this issue Nov 12, 2012 · 3 comments
Closed

delete cannot be executed without a --rel argument. #15

nebhale opened this issue Nov 12, 2012 · 3 comments

Comments

@nebhale
Copy link
Contributor

nebhale commented Nov 12, 2012

Currently, executing the delete command requires the --rel argument to be specified. This means that you cannot do the following to delete a resource and verify that it is deleted.

follow foo
delete
get

The delete command should be allowed to run from any URI without the --rel argument specified and should simply execute an HTTP DELETE on the current URI. The --rel behavior should be preserved as-is.

@jbrisbin
Copy link
Contributor

It's not the --rel that's required but an argument of some kind. --rel is actually a convenience switch because the PathOrRel object that is the first parameter to the delete command figures out whether it's being passed a rel value or an actual path.

But it would be easier (and more consistent with the other commands) to not require a path or rel value on delete. I think it's as easy a fix as turning the mandatory switch to false.

@nebhale
Copy link
Contributor Author

nebhale commented Nov 12, 2012

Has the forked code mentioned in #10 made it back into spring-shell yet?

/cc @markpollack

@jbrisbin
Copy link
Contributor

Just created a PR for that spring-projects/spring-shell#3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants