Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LocaleRoot when using Strings toLowerCase/toUpperCase #489

Closed
cppwfs opened this issue Nov 5, 2024 · 0 comments
Closed

Use LocaleRoot when using Strings toLowerCase/toUpperCase #489

cppwfs opened this issue Nov 5, 2024 · 0 comments
Assignees
@corneil

Comments

@cppwfs
Copy link
Contributor

cppwfs commented Nov 5, 2024 •
edited by onobc
Loading

Update Deployer to add Locale.ROOT for String toLowerCase/toUpperCase.

Note

If we want to also prevent this in the future we can add checkstyle rules as done in spring-projects/spring-pulsar@123b17d
@cppwfs cppwfs assigned cppwfs and unassigned cppwfs Nov 6, 2024
@corneil corneil self-assigned this Nov 7, 2024
corneil added a commit to corneil/spring-cloud-deployer that referenced this issue Nov 7, 2024
@corneil
Updated toLowerCase() to toLowerCase(Locale.ROOT) and toUpperCase() t…
98d9f38 
…o toUpperCase(Locale.ROOT)

Fixes spring-cloud#489
corneil added a commit to corneil/spring-cloud-deployer that referenced this issue Nov 7, 2024
@corneil
Updated toLowerCase() to toLowerCase(Locale.ROOT) and toUpperCase() t…
bf1df97 
…o toUpperCase(Locale.ROOT)

Fixes spring-cloud#489
corneil added a commit to corneil/spring-cloud-deployer that referenced this issue Nov 7, 2024
@corneil
Updated toLowerCase() to toLowerCase(Locale.ROOT) and toUpperCase() t…
daad886 
…o toUpperCase(Locale.ROOT)

Fixes spring-cloud#489
@corneil corneil mentioned this issue Nov 7, 2024
Merged
onobc pushed a commit that referenced this issue Nov 7, 2024
@corneil
Specify locale in toLowerCase|toUpperCase (#491)
6f1fd99 
This commit makes sure that all usages of String toLowerCase and
toUpperCase specify a Locale (default of Locale.ROOT).

Fixes #489
@onobc onobc closed this as completed in 552f57f Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corneil corneil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corneil @cppwfs