Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exclusions using .gitignore #14

Open
rwinch opened this issue Jun 6, 2019 · 6 comments
Open

Support exclusions using .gitignore #14

rwinch opened this issue Jun 6, 2019 · 6 comments

Comments

@rwinch
Copy link
Collaborator

rwinch commented Jun 6, 2019

It would be nice if the Gradle plugin could support excluding files based upon the .gitignore file.

@JLLeitschuh
Copy link

Interestingly, you may not want to do this.
For example, if you have something that generates code into the Gradle build/ directory, you'd want to be alerted that that generated code is using http.

@rwinch
Copy link
Collaborator Author

rwinch commented Jun 7, 2019

While you might not, there is a good chance you do want to ignore all the IDE metadata that you have no control over. In either case, I think it would be up to the project to decide.

@JLLeitschuh
Copy link

In either case, I think it would be up to the project to decide.

Agreed!

@simonbasle
Copy link

I came across this issue while running ./gradlew nohttp locally and getting a lot of complains from under .idea/... @rwinch maybe using git check-ignore command would be a possibility, as a second-pass filter?

@rwinch
Copy link
Collaborator Author

rwinch commented Jan 28, 2021

Thanks @simonbasle. I think that would be a good and simple way to implement this. I do hesitate a bit on requiring a binary be installed (i.e. git), so it would certainly have to be an opt in item. Any chance you are interested in providing a PR?

@simonbasle
Copy link

Any chance you are interested in providing a PR?

Sorry I just saw that part of the message. I'm not able to provide a PR at this time, so if somebody else wants to take it go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants