Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autocovariance -> posterior::autocovariance #215

Merged
merged 1 commit into from
Mar 25, 2023
Merged

autocovariance -> posterior::autocovariance #215

merged 1 commit into from
Mar 25, 2023

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Mar 24, 2023 •
edited
Loading

closes #157

Replace's loo's internal autocovariance() function with posterior::autocovariance()

@jgabry jgabry mentioned this pull request Mar 24, 2023
Open
@jgabry jgabry requested a review from avehtari March 24, 2023 18:21
avehtari
avehtari approved these changes Mar 25, 2023
View reviewed changes
Copy link
Collaborator

@avehtari avehtari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jgabry jgabry merged commit 1832085 into master Mar 25, 2023
@jgabry jgabry deleted the replace-autocovariance branch March 25, 2023 21:54
@jgabry jgabry mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avehtari avehtari avehtari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use posterior::autocovariance() once on CRAN
2 participants
@jgabry @avehtari