Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages are delivered with delay #21850

Open
pavloburykh opened this issue Dec 19, 2024 · 7 comments
Open

Messages are delivered with delay #21850

pavloburykh opened this issue Dec 19, 2024 · 7 comments
Labels
mobile-core re-check waku All issues relating to the Status Waku integration.
Milestone

Comments

@pavloburykh
Copy link
Contributor

cc @chaitanyaprem @richard-ramos @plopezlpz @qfran @ilmotta

Currently go develop seems to be broken in terms of data delivery. The presumed culprit commit is status-im/status-go@e7cc535

Issue has been initially reported here

Below you can see example of 1 min delay between messages.

Check out the video:

sender_receiver.mp4

Logs for sender: logs (27).zip
Logs for receiver: receiver.zip

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
@pavloburykh pavloburykh added the waku All issues relating to the Status Waku integration. label Dec 19, 2024
@chaitanyaprem
Copy link
Contributor

It could probably be due to rate-limiters added.
I have a fix for it here along with a bunch of other fixes.

I was waiting for more testing to be done, can you test the mobile PR which includes this fixes and update if things are working fine.
Then i will merge this so that develop will become sane again.

cc @pavloburykh

@pavloburykh
Copy link
Contributor Author

It could probably be due to rate-limiters added. I have a fix for it here along with a bunch of other fixes.

I was waiting for more testing to be done, can you test the mobile PR which includes this fixes and update if things are working fine. Then i will merge this so that develop will become sane again.

cc @pavloburykh

@chaitanyaprem thank you. We will perform testing of the PR and let you know about the results.

@chaitanyaprem
Copy link
Contributor

@pavloburykh , can we close this issue now that status-im/status-go#5964 is merged?

@pavloburykh
Copy link
Contributor Author

pavloburykh commented Dec 23, 2024

status-im/status-go#5964

@chaitanyaprem we will close it once we get the fix into mobile develop when we bump status go version.

@ilmotta
Copy link
Contributor

ilmotta commented Dec 23, 2024

@pavloburykh do you want to proactively bump status-go in mobile develop or do you prefer to wait until eventually a mobile PR picks up the changes from status-im/status-go#5964 ? If the former, let me know and I will raise a PR.

@pavloburykh
Copy link
Contributor Author

@pavloburykh do you want to proactively bump status-go in mobile develop or do you prefer to wait until eventually a mobile PR picks up the changes from status-im/status-go#5964 ? If the former, let me know and I will raise a PR.

@ilmotta I would prefer to bump now. Please let me know when you create the PR so I trigger full e2e run before merging. Thank you for help.

@churik
Copy link
Member

churik commented Dec 26, 2024

@pavloburykh
please, re-check after #21865 and close if it is not reproducible, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile-core re-check waku All issues relating to the Status Waku integration.
Projects
Status: No status
Development

No branches or pull requests

4 participants