Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespaces to ZED code #130

Open
DanielPD opened this issue Jun 8, 2020 · 2 comments
Open

Add namespaces to ZED code #130

DanielPD opened this issue Jun 8, 2020 · 2 comments

Comments

@DanielPD
Copy link

DanielPD commented Jun 8, 2020

Currently the ZED codebase doesn't seem to use namespaces everywhere. Some parts do (e.g. the SDK/NativeInterface classes use namespace "s1"), while the majority of classes don't (e.g. SDK/Helpers/Scripts). This may cause conflicts with other plugins and assets when imported in Unity.

Specifically, I recently ran into a problem using ZED and UMA. UMA defines its own helper classes under its own namespace, which includes a class ReadOnlyAttribute to manage read-only attributes. Similarly, ZED defines a ReadOnlyAttribute class, without namespace, causing a conflict.

@RomanCalderon
Copy link

Having a similar issue here. Namespacing all ZED scripts would be very helpful!

@prof-thies-pfeiffer
Copy link

In particular the ReadOnly attribute (Util.cs) is used in many assets, e.g. Convai, and each time we encounter conflicts with ZED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants