Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow path with spaces in Obsidian markdown wikilink-style images #1718

Open
stevencohn opened this issue Dec 23, 2024 · 0 comments · Fixed by #1719 or #1720
Open

Allow path with spaces in Obsidian markdown wikilink-style images #1718

stevencohn opened this issue Dec 23, 2024 · 0 comments · Fixed by #1719 or #1720
Assignees
@stevencohn
Labels
feature-request New feature or request next-release Addressed but not yet released

Comments

@stevencohn
Copy link
Owner

Problem to Solve

Previously, we disallowed spaces in the path of markdown files. But this was only a restriction due to the way wikilink-style image specifiers were double-encoded, causing %20 to become %2520.

This change patches the double-encoded source path to allow spaces in image paths.
@stevencohn stevencohn added the feature-request New feature or request label Dec 23, 2024
@stevencohn stevencohn self-assigned this Dec 23, 2024
stevencohn added a commit that referenced this issue Dec 23, 2024
@stevencohn
Fix wikilinks spacing issue
50532b6 
#1718
@stevencohn stevencohn mentioned this issue Dec 23, 2024
Merged
stevencohn added a commit that referenced this issue Dec 23, 2024
@stevencohn
Fix wikilinks spacing issue (#1719)
9ceca41 
#1718
@stevencohn stevencohn added the next-release Addressed but not yet released label Dec 23, 2024
@stevencohn stevencohn linked a pull request Dec 23, 2024 that will close this issue
Fix wikilinks spacing issue #1719
Merged
@stevencohn stevencohn mentioned this issue Dec 23, 2024
Closed
stevencohn added a commit that referenced this issue Dec 23, 2024
@stevencohn
1718 better solution
4d4fbf5 
#1718
@stevencohn stevencohn mentioned this issue Dec 23, 2024
Merged
stevencohn added a commit that referenced this issue Dec 23, 2024
@stevencohn
1718 better solution (#1720)
dc0a3f1 
#1718
@stevencohn stevencohn linked a pull request Dec 23, 2024 that will close this issue
1718 better solution #1720
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevencohn stevencohn

Labels
feature-request New feature or request next-release Addressed but not yet released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wikilinks spacing issue stevencohn/OneMore
1718 better solution stevencohn/OneMore
1 participant
@stevencohn