Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update sprocket to latest WDL crate #46

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

a-frantz
Copy link
Member

@a-frantz a-frantz commented Dec 17, 2024

This also adds the ability to check/lint URLs

closes #39
sort of closes #45 by providing --local-only and --single-document args which narrow the scope of printed diagnostics. It was decided over slack not to pursue either of the 2 fixes presented in #45 as they were likely undesirable UXs.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these changes (when appropriate).

This also adds the ability to check/lint URLs
@a-frantz a-frantz requested a review from peterhuene December 17, 2024 22:51
@a-frantz a-frantz self-assigned this Dec 17, 2024
@a-frantz a-frantz marked this pull request as ready for review December 18, 2024 15:28
CHANGELOG.md Outdated Show resolved Hide resolved
@a-frantz a-frantz marked this pull request as draft December 18, 2024 16:31
@a-frantz
Copy link
Member Author

This PR was put back into draft state and will remain as a draft until the wdl crates make an official release. In the meantime, I'll use this branch as the basis for the development of the other sprocket PRs I have planned.

This PR will have to be reviewed+merged before those other ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants