Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update builder.h #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update builder.h #3

wants to merge 1 commit into from

Conversation

curtis-sun
Copy link

@curtis-sun curtis-sun commented Jun 17, 2022 •
edited
Loading

  1. In function "Finalize", if range and num_bins_ are both power of 2, variable "shift_" shoule plus 1 more. Otherwise, the range of shifted keys may be beyond the bound specified by num_bins_.
  2. In function "TransformIntoRadixTable", tree_.front().second[max_prefix+1] is not assigned.

@curtis-sun
Update builder.h
236101b 
1. In function "Finalize", if range and num_bins_ are both power of 2, shift_ shoule plus 1 to adapt to num_bins.
2. In function "TransformIntoRadixTable", tree_.front().second[max_prefix+1] is not assigned.
@stoianmihail
Copy link
Owner

Hi, Curtis!

First, thanks for patch! I'll take a closer look on week-end.

Until then, could you please fix the typos in the first subcomment? I mean this part: "shift_ shoule plus 1 to adapt to num_bins" -- this way we avoid any confusion of what's meant. Thanks!

@stoianmihail stoianmihail reopened this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curtis-sun @stoianmihail