Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodes, accessors): fix validations with $ref nodes #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CptKirk
Copy link

@CptKirk CptKirk commented Mar 18, 2024

Allow usage of readOnly and WriteOnly tags on $ref nodes

fix #34

Motivation and Context

See #34

Description

When setting node validations, the original fragment is also passed to the function to be able to parse readOnly and writeOnly tags. If no original fragment is provided, the function works as before, to not introduce breaking changes.

How Has This Been Tested?

Unit tests were added to assure correct validation.

Screenshot(s)/recordings(s)

See #34

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Allow usage of readOnly and WriteOnly tags on $ref nodes

fix stoplightio#34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ref validations not working as expected
1 participant