Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@storybook/addon-knobs install in devDependencies #5

Open
cksal0805 opened this issue Apr 8, 2021 · 1 comment
Open

@storybook/addon-knobs install in devDependencies #5

cksal0805 opened this issue Apr 8, 2021 · 1 comment

Comments

@cksal0805
Copy link

The storybook documentation tells you to install it in'devDependency',
but if you install it in'devDependency',
it says" '@storybook/addon-knobs' should be listed in the project's dependencies, not devDependencies. "

Looking at the packages, it seems that there are some packages that are used in production mode.
Is it correct to install it on devDependency?

@shilman
Copy link
Member

shilman commented Apr 9, 2021

@storybook/* packages should generally be listed in devDependencies because you are using them to develop your app/library/design system, but you don't want to ship those dependencies with your app/library/design system. Do you know what's printing that warning?

===

Also, FYI, we’ve released addon-controls in Storybook 6.0. Controls are portable, auto-generated knobs that are intended to replace addon-knobs, which are slated for deprecation.

Please upgrade and try out controls today!

@shilman shilman transferred this issue from storybookjs/storybook May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants