Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add rate limit to public APIs #148

Open
akiraonstarknet opened this issue Sep 28, 2024 · 18 comments · May be fixed by #195
Open

feature: Add rate limit to public APIs #148

akiraonstarknet opened this issue Sep 28, 2024 · 18 comments · May be fixed by #195
Assignees
Labels
enhancement New feature or request

Comments

@akiraonstarknet
Copy link
Contributor

No description provided.

@akiraonstarknet akiraonstarknet added the enhancement New feature or request label Sep 28, 2024
@akiraonstarknet akiraonstarknet self-assigned this Sep 28, 2024
@Iwueseiter
Copy link
Contributor

Hi @akiraonstarknet can I work on this?

@Jemiiah
Copy link
Contributor

Jemiiah commented Sep 28, 2024

@akiraonstarknet can I work on this issue

@akiraonstarknet
Copy link
Contributor Author

Hey @Iwueseiter @Jemiiah, sorry. Am working on this for faster closure.

@Jemiiah
Copy link
Contributor

Jemiiah commented Sep 28, 2024

suree chief 🫡

@Jemiiah
Copy link
Contributor

Jemiiah commented Oct 11, 2024

@akiraonstarknet i would love to work on this issue with an ETA of 48hours

@akiraonstarknet
Copy link
Contributor Author

@Jemiiah can u share your approach to do this (technically)

@akiraonstarknet akiraonstarknet removed their assignment Oct 14, 2024
@Benjtalkshow
Copy link
Contributor

Hello @akiraonstarknet
Is this issue open for contribution? I would love to tackle this issue. Thanks

@jedstroke
Copy link

Hello @akiraonstarknet
Is this issue available ser?

@Benjtalkshow
Copy link
Contributor

@akiraonstarknet
is this issue open for contribution? I want to work on it.

@martinvibes
Copy link
Contributor

Hello sir @akiraonstarknet I would like to work on this issue

@Benjtalkshow
Copy link
Contributor

Benjtalkshow commented Oct 27, 2024

Hello @akiraonstarknet , I would love to work on this task.
I am a Full Stack Developer specializing in Next.js, TypeScript, Node.js, Cairo and Rust . With over 31 contributions across projects in the OnlyDust ecosystem, I’ve developed strong proficiency in delivering high-quality solutions and resolving complex issues within tight deadlines. My experience spans frontend, backend, smart contracts, and the optimization and maintenance of scalable codebases.

Here is my approach to solving this issue:

Since this project is built with nextjs, I will create a middleware file to intercept requests before they reach our API routes.
I will choose the most suitable storage solution, We'll use Upstash Redis for storing rate limit data. It's compatible with Vercel's edge runtime.
Then i will use the @upstash/ratelimit library to define and enforce rate limits, Set appropriate limits based on our API requirements. We can set rate limit of 5 requests per 10 seconds or more depending on our API requirement.

Lastly, i will return appropriate responses when rate limits are exceeded.
This solution is scalable, works well with Vercel's edge runtime, and provides a solid foundation for rate limiting our app's API routes.
Thank you.

@ShantelPeters
Copy link

Hi @akiraonstarknet can i please work on this ?

@Jemiiah
Copy link
Contributor

Jemiiah commented Nov 5, 2024

@akiraonstarknet pls kindly assign ready to work on this 🔥🔥

@Benjtalkshow
Copy link
Contributor

Hi @akiraonstarknet
I am still available for this task. Thanks

@akiraonstarknet
Copy link
Contributor Author

@Benjtalkshow msg me on tg to talk more on this

@Benjtalkshow
Copy link
Contributor

@Benjtalkshow msg me on tg to talk more on this

Alright

@Benjtalkshow
Copy link
Contributor

Hello @akiraonstarknet
i am still working on this. Will make PR soon. I just wanted to let you know. Thanks

@Benjtalkshow Benjtalkshow linked a pull request Dec 12, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants