Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails when target is /adb::/sdcard #8

Open
divansantana opened this issue Jul 25, 2018 · 3 comments
Open

fails when target is /adb::/sdcard #8

divansantana opened this issue Jul 25, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@divansantana
Copy link

Hello,

This is a great addition to the community. Thanks for it!

Just thought I'd let you know, this doesn't seem to work with adb unfortunately.

I get an error like this:

ssh: Could not resolve hostname : Name or service not known
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: unexplained error (code 255) at io.c(226) [sender=3.1.3]
@stsquad
Copy link
Owner

stsquad commented Aug 3, 2018

Can you actually rsync over adb? I suspect this is because we are just using tramp-remote-file-p rather than specifically testing we are on an ssh connection. Of course we could detect adb and use a different handler in that case (adb push/adb pull?).

@divansantana
Copy link
Author

TBH I realised the next morn I was being a bit silly because its adb.

Suppose the main issue is using adb in emacs is sync and not async so it hangs with large file copies. Would be nice to use something async like dired-rsync.

@stsquad
Copy link
Owner

stsquad commented Aug 8, 2018

@divansantana there is no reason why the same sort of approach can't be done - in fact the code would be almost identical, just invoking a different inferior command.

@stsquad stsquad added the enhancement New feature or request label Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants