Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppNavigator documentation #287

Open
RazvanRotaru opened this issue Sep 26, 2021 · 0 comments
Open

AppNavigator documentation #287

RazvanRotaru opened this issue Sep 26, 2021 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@RazvanRotaru
Copy link

When the final design for the routing is ready, please document it in CONTRIBUTING.md. It's important to have some instructions about how to properly create a new page/route (not in this PR).

(it may also be worth introducing some automated checks, e.g. if someone uses Navigator instead of AppNavigator to refer them to the routing documentation; and on that note -- what happens if e.g. someone does use AppNavigator but didn't implement a route in this file? we should try to make the error message informative so people don't get stuck on this)

Originally posted by @IoanaAlexandru in #265 (comment)

@RazvanRotaru RazvanRotaru added the documentation Improvements or additions to documentation label Sep 26, 2021
@RazvanRotaru RazvanRotaru self-assigned this Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant