Feature/147 icon add the new social network x icon #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export SizeUnchanged@studiometa/ui
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #148 +/- ##
========================================
Coverage 26.34% 26.34%
========================================
Files 46 46
Lines 1154 1154
Branches 216 216
========================================
Hits 304 304
Misses 784 784
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
titouanmathis
requested changes
Oct 23, 2023
There was a problem hiding this comment.
@coraliebach can you add it to the demo in the docs as well?
You can find the template for the demo here: packages/docs/components/atoms/IconInline/stories/app.twig.
10 tasks
|
Obsolete with the changes in #201. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add the svg file of the new social network X.