Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpandRel output type discrepancy #714

Open
vbarua opened this issue Sep 26, 2024 · 1 comment
Open

ExpandRel output type discrepancy #714

vbarua opened this issue Sep 26, 2024 · 1 comment

Comments

@vbarua
Copy link
Member

vbarua commented Sep 26, 2024

The protobuf comment

In addition to a field being emitted per input field an extra int64 field is emitted

Disagrees with the written spec:

The expand fields followed by an i32 column describing the index of the duplicate that the row is derived from.

We should reconcile this.

@Blizzara
Copy link
Contributor

Blizzara commented Nov 8, 2024

Should it be "i32 or i64 field", allowing both? At least in Spark the type of the field depends on some config option, defaulting now to i64 but earlier i32: https://github.com/apache/spark/blob/master/docs/sql-migration-guide.md#upgrading-from-spark-sql-30-to-31 (see second item).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants