Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍪 Revisit bulk renewals success message for users with 50+ titles 🍪 #465

Open
cbeer opened this issue Aug 12, 2019 · 3 comments
Open
Labels
bug Something isn't working

Comments

@cbeer
Copy link
Member

cbeer commented Aug 12, 2019

Backtrace

View full backtrace and more info at honeybadger.io

@camillevilla camillevilla added the bug Something isn't working label Aug 12, 2019
@camillevilla
Copy link
Contributor

In this case, we had a patron attempt to renew 53 items. This created an ENORMOUS cookie because flashes included every title.

One proposed solution from @cbeer included passing IDs instead of full title strings to the flash message, and then using the IDs to fetch titles on the page.

@camillevilla camillevilla changed the title [mylibrary/prod] ActionDispatch::Cookies::CookieOverflow: ActionDispatch::Cookies::CookieOverflow 🍪 Bulk renewals success message for users with 50+ titles 🍪 Aug 27, 2019
@camillevilla camillevilla changed the title 🍪 Bulk renewals success message for users with 50+ titles 🍪 🍪 Revisit bulk renewals success message for users with 50+ titles 🍪 Aug 27, 2019
@corylown
Copy link
Contributor

Another solution would be to stop relying on flash messages and use turbo/hotwire to display bulk renewal response information in the UI.

@jcoyne
Copy link
Contributor

jcoyne commented Sep 27, 2023

Another idea is to say "X, Y, Z and 52 other titles have been renewed". If they have so many, then it's unlikely that they are going to get any utility out of seeing all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants