Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update header/footer for file viewer #1906

Open
dbranchini opened this issue Dec 4, 2023 · 2 comments
Open

Update header/footer for file viewer #1906

dbranchini opened this issue Dec 4, 2023 · 2 comments
Labels
design

Comments

@dbranchini
Copy link

Originally part of a redesign of the file viewer - See #1849 and https://www.figma.com/proto/LVP13xZ0HhrxAPHCnoMVW1/Embedded-File-Viewer?page-id=0%3A1&type=design&node-id=316-1113&viewport=-2703%2C-153%2C0.5&t=drUPK0C4xcXsgdsS-1&scaling=min-zoom&starting-point-node-id=316%3A1113&mode=design for reference.

In order to solve accessibility issues, we decided to make #1849 focused on the files/folders UI. We split out the header and footer work into this ticket. The larger question to answer - should this ticket include all viewers (except the Mirador book viewer and the media viewer since that's being handled separately)?
@thatbudakguy
Copy link
Member

I think we should keep this ticket scoped to the file viewer and open a separate one related to doing all the other headers/footers.

@lwrubel lwrubel removed the question label Dec 4, 2023
@lwrubel
Copy link
Contributor

lwrubel commented Dec 4, 2023

Moving to backlog pending a more comprehensive analysis across viewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lwrubel @thatbudakguy @dbranchini