Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should the UI present when there are two simultaneously applicable access restrictions? #2000

Open
jmartin-sul opened this issue Dec 13, 2023 · 0 comments
Labels

Comments

@jmartin-sul
Copy link
Member

Currently, we show two banners, e.g.:

https://sul-purl-stage.stanford.edu/pw790hw4975

Screenshot 2023-12-13 at 10 25 27 AM

Currently, this also has the side effect of pushing the player down to the point that the controls are no longer visible/clickable, because the CSS for determining player size when banners are present doesn't account for the possibility of two banners 1. In the case of this example object, the lack of player controls isn't really a functionality issue, since the object is totally embargoed (and thus unstreamable) till 2025. But I'm not sure if that'll be the case for all multi-banner restriction scenarios?

Footnotes

  1. I'm not sure offhand whether that sort of additional conditional logic would also require some JS code, or whether it could be done solely in CSS, as the player resizing for a single banner currently is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant