Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't display auto-generated captions by default #2275

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

don't display auto-generated captions by default #2275

wants to merge 1 commit into from

Conversation

dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Dec 5, 2024

closes #2262

@dnoneill dnoneill force-pushed the auto-generated-captions branch from 22d5e20 to 75e7789 Compare December 5, 2024 22:00
@peetucket
Copy link
Member

LGTM. There are conflicts now, may be worth re-basing to avoid even more divergence.

@dnoneill
Copy link
Contributor Author

Not really ready for review. #2267 needs to be merged first

Base automatically changed from auto-generated-captions to main December 17, 2024 22:10
@dnoneill dnoneill force-pushed the 2262-uncorrect-default branch from 637f561 to fae93a1 Compare December 17, 2024 22:33
@dnoneill dnoneill marked this pull request as ready for review December 17, 2024 22:33
@dnoneill
Copy link
Contributor Author

@peetucket ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not display uncorrected captions by default
2 participants
@dnoneill @peetucket