Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail Callback URL Formatted Incorrectly #9

Open
robwatkiss opened this issue Dec 5, 2018 · 4 comments
Open

Fail Callback URL Formatted Incorrectly #9

robwatkiss opened this issue Dec 5, 2018 · 4 comments

Comments

@robwatkiss
Copy link

When the callbackfail URL is called it is incorrectly formatted and places the query parameters before other parts of the URL needed for some web apps using /# based routing.

Expected Redirect: https://some.website.com/#/callback/payment-fail?smpt-status=failed
Actual Redirect: https://some.website.com/?smpt-status=failed#/callback/payment-fail

@mollidor
Copy link
Contributor

Hi @robwatkiss

Nice catch and thanks for debugging this. Can you provide an example URL you call (including the callback you would expect) so I can add it to our tests?

Best,
Lukas

@robwatkiss
Copy link
Author

Hi @mollidor - here's that example for you:

sumupmerchant://pay/1.0?affiliate-key=00000000-0000-0000-0000-000000000000&app-id=com.company.pointofsale.test&amount=1.56&currency=CHF&title=Test%20Title&callbacksuccess=https%3A%2F%2Fpos.website.com%2F%23%2Fcallback%2Fpayment-success&callbackfail=https%3A%2F%2Fpos.website.com%2F%23%2Fcallback%2Fpayment-fail

@mollidor
Copy link
Contributor

mollidor commented Dec 13, 2018

Thanks a lot. So you would expect us to open
https://pos.website.com/#/callback/payment-fail?smpt-status=failed
but we do open
https://pos.website.com/?smpt-status=failed#/callback/payment-fail

Is that what you observe?

@robwatkiss
Copy link
Author

That's correct, yep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants