You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behaviour
A git clone should work out of the box or error / warn if dependencies are missing.
Actual behaviour
Git clone is installed correctly in develop mode. Module can be imported, client can be instantiated, but has the attributes client.model_1, client.model_111, ... instead of the expected client.common, client.inverter, ...
Suggested fix
Error out or warn the user / developer that the model definitions could not be found.
Notes
The README states that the clone should have --recursive for the git submodules, but that may be overlooked in development, customized or automated installations. This is to warn / fail early in case of an inconsistent and non-functioning installation.
The text was updated successfully, but these errors were encountered:
Expected behaviour
A git clone should work out of the box or error / warn if dependencies are missing.
Actual behaviour
Git clone is installed correctly in develop mode. Module can be imported, client can be instantiated, but has the attributes
client.model_1
,client.model_111
, ... instead of the expectedclient.common
,client.inverter
, ...Steps to reproduce
and then try an example such as https://pysunspec.readthedocs.io/en/latest/pysunspec.html#interacting-with-a-sunspec-device.
Suggested fix
Error out or warn the user / developer that the model definitions could not be found.
Notes
The README states that the clone should have
--recursive
for the git submodules, but that may be overlooked in development, customized or automated installations. This is to warn / fail early in case of an inconsistent and non-functioning installation.The text was updated successfully, but these errors were encountered: