Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: import open zepplin or solmate properly and make upgrade to 0.8 #17

Open
Ro5s opened this issue Aug 26, 2021 · 1 comment
Open

enhancement: import open zepplin or solmate properly and make upgrade to 0.8 #17

Ro5s opened this issue Aug 26, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Ro5s
Copy link
Contributor

Ro5s commented Aug 26, 2021 •
edited
Loading

Currently MISO token launchpad uses older versions of OpenZeppelin helper and token contracts, compiler hardcoded at 0.6.12, stored locally here.

It might make more sense to import these contracts from OZ codebase (so we track upgrades, simplify MISO repo, use >=0.8.0 solidity), or in the alternative, explore using Solmate templates. which are simpler, more opinionated and gas-optimized.
@matthewlilley
Copy link
Member

@Ro5s just said earlier that we should import OZ properly, but would be keen to see an update using Solmate & 0.8. You keen?

@matthewlilley matthewlilley changed the title simplify codebase by using OZ or Solmate imports enhancement: import open zepplin or solmate properly and make upgrade to 0.8 Jan 8, 2022
@matthewlilley matthewlilley added enhancement New feature or request help wanted Extra attention is needed labels Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthewlilley @Ro5s