Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to postcss-load-config 5.0 #636

Open
ai opened this issue Dec 1, 2023 · 7 comments · May be fixed by #665
Open

Move to postcss-load-config 5.0 #636

ai opened this issue Dec 1, 2023 · 7 comments · May be fixed by #665

Comments

@ai
Copy link

ai commented Dec 1, 2023

This project is using postcss-load-config 3.0, but the latest version is 5.0.

In new version we removed Node.js 12—16, improved ESM and TS support, and moved to async API.
@ota-meshi
Copy link
Member

ESLint currently needs to work synchronously, so we can't use the new version of postcss-load-config where the sync API has been dropped 😓

@ai
Copy link
Author

ai commented Dec 1, 2023

It was dropped because of ESM/TS support where we have only async API.

Is it possible to preload config by async API in some initializer before ESLint rules call?

@ota-meshi
Copy link
Member

I've been looking for it many times but can't find it.
Probably not supported.
eslint/eslint#15394

If we need to upgrade postcss-load-config right now, I think we'll probably need to use something like synckit to synchronize it.
https://github.com/un-ts/synckit

@JounQin
Copy link
Collaborator

JounQin commented Jan 11, 2024 •
edited
Loading

Is there anything blocked? I believe @ota-meshi is very similar with synckit, and if you agree I can raise a PR for it.

@ota-meshi
Copy link
Member

I'm sure that using synckit could solve the problem, but I don't have the time to implement it right now 😓

@JounQin
Copy link
Collaborator

JounQin commented Jan 11, 2024

I'm sure that using synckit could solve the problem, but I don't have the time to implement it right now 😓

and if you agree I can raise a PR for it.

I'll raise a PR for it.

JounQin added a commit that referenced this issue Jan 11, 2024
@JounQin
feat: use synckit to support postcss-load-config v5
8c8ce97 
close #636
@JounQin JounQin linked a pull request Jan 11, 2024 that will close this issue
Open
@JounQin
Copy link
Collaborator

JounQin commented Jan 11, 2024

@ota-meshi Here you are. #665

JounQin added a commit that referenced this issue Jan 11, 2024
@JounQin
feat: use synckit to support postcss-load-config v5
89ed209 
close #636
JounQin added a commit that referenced this issue Jan 11, 2024
@JounQin
feat: use synckit to support postcss-load-config v5
b23d36f 
close #636
JounQin added a commit that referenced this issue Jan 11, 2024
@JounQin
feat: use synckit to support postcss-load-config v5
69445ac 
close #636
JounQin added a commit that referenced this issue Jan 11, 2024
@JounQin
feat: use synckit to support postcss-load-config v5
fef7962 
close #636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use synckit to support postcss-load-config v5 sveltejs/eslint-plugin-svelte
3 participants
@ai @JounQin @ota-meshi