fix: Allow unquoted slash in attributes #14615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ea9d4cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
preview: https://svelte-dev-git-preview-svelte-14615-svelte.vercel.app/ this is an automated message |
|
|
Thank you — this fails with |
Hi, please let me know if this fixes the issue. Thanks! |
Rich-Harris
approved these changes
Dec 12, 2024
Rich-Harris
reviewed
Dec 12, 2024
|
perfect, thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to allow unquoted slashes in attributes within the Svelte compiler. The key changes include modifications to the parser to handle unquoted slashes, as well as updates to the test cases to ensure this new feature is properly validated.
Changes to the Svelte compiler:
packages/svelte/src/compiler/phases/1-parse/state/element.js: Modified theread_attributefunction to handle unquoted slashes in attribute values. When it's an unquoted slash, parser will handle it as a quoted slash.Updates to test cases:
packages/svelte/tests/parser-legacy/samples/attribute-unquoted/input.svelte: Added a new test case for an anchor tag with an unquoted slash in thehrefattribute.packages/svelte/tests/parser-legacy/samples/attribute-unquoted/output.json: Updated the expected output JSON to reflect the new test case and ensure the parser correctly handles the unquoted slash. [1] [2]Documentation:
.changeset/long-boxes-flow.md: Added a changeset entry to document the new feature allowing unquoted slashes in attributes.Issues Related:
#7782