Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source compatibility project penny-bot fails with a compiler error #75500

Closed
eeckstein opened this issue Jul 26, 2024 · 1 comment · Fixed by #75489 or #75526
Closed

source compatibility project penny-bot fails with a compiler error #75500

eeckstein opened this issue Jul 26, 2024 · 1 comment · Fixed by #75489 or #75526
Assignees
@gregomni
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler itself Foundation Linux Platform: Linux multiple modules Flag: An issue whose reproduction requires multiple modules name lookup Area → compiler → type checker: Name lookup source compatibility suite Flag: An issue that surfaced in the source compatibility suite swift 6.0 type checker Area → compiler: Semantic analysis type declarations Feature → declarations: Type declarations unexpected error Bug: Unexpected error

Comments

@eeckstein
Copy link
Contributor

Description

/build/swift-source-compat-suite/project_cache/penny-bot/Sources/Penny/Services/AutoPingsService/DefaultPingsService.swift:20:44: error: reference to generic type 'Expression' requires arguments in <...>
 18 |     var _cachedItems: S3AutoPingItems?
 19 |     /// `[ExpressionHash: Expression]`
 20 |     var _cachedExpressionsHashTable: [Int: Expression]?
    |                                            `- error: reference to generic type 'Expression' requires arguments in <...>
 21 |     var resetItemsTask: Task<(), Never>?
 22 |

Reproduction

builds:
https://ci.swift.org/job/swift-6.0-source-compat-suite-debug-ubuntu-2004/121/
https://ci.swift.org/job/swift-6.0-source-compat-suite-ubuntu-2004/121/
https://ci.swift.org/job/swift-source-compat-suite-debug-ubuntu-2004/499/
https://ci.swift.org/job/swift-source-compat-suite-ubuntu-2004/599/

log: https://ci.swift.org/job/swift-6.0-source-compat-suite-debug-ubuntu-2004/121/artifact/build/swift-source-compat-suite/FAIL_penny-bot_5.10_BuildSwiftPackage.log

Expected behavior

should build fine

Environment

CI

Additional information

Note: in recent builds this might be hidden by another problem:

/Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite/swift-source-compat-suite/project_cache/penny-bot/.build/checkouts/DiscordBM/Sources/DiscordModels/Types/Permission.swift:3:1: error: cannot specialize non-generic type '() -> ()'
 1 | 
 2 | /// https://discord.com/developers/docs/topics/permissions#permissions-bitwise-permission-flags
 3 | @UnstableEnum<UInt>
   | `- error: cannot specialize non-generic type '() -> ()'
 4 | public enum Permission: Sendable, Codable {
 5 |     case createInstantInvite // 0

which should be fixed with the revert #75489
@eeckstein eeckstein added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels labels Jul 26, 2024
@AnthonyLatsis AnthonyLatsis linked a pull request Jul 26, 2024 that will close this issue
Revert "[Sema] Add specialization constraints for func and variable types, then diagnose w/fixes." #75489
Merged
@AnthonyLatsis AnthonyLatsis added compiler The Swift compiler itself type checker Area → compiler: Semantic analysis source compatibility suite Flag: An issue that surfaced in the source compatibility suite expressions Feature: expressions unexpected error Bug: Unexpected error swift 6.0 swift macro Feature → declarations: Swift `macro` declarations generics Feature: generic declarations and types types Feature: types and removed triage needed This issue needs more specific labels expressions Feature: expressions swift macro Feature → declarations: Swift `macro` declarations labels Jul 26, 2024
@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Jul 26, 2024 •
edited
Loading

Ditto swiftlang/swift-source-compat-suite#955. Link to file.

@AnthonyLatsis AnthonyLatsis added name lookup Area → compiler → type checker: Name lookup Foundation type declarations Feature → declarations: Type declarations Linux Platform: Linux multiple modules Flag: An issue whose reproduction requires multiple modules and removed generics Feature: generic declarations and types types Feature: types labels Jul 26, 2024
@gregomni gregomni self-assigned this Jul 27, 2024
@gregomni gregomni mentioned this issue Jul 27, 2024
Merged
@gregomni gregomni linked a pull request Jul 27, 2024 that will close this issue
[Sema] Improve diagnoses of generic specializations #75526
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregomni gregomni

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler itself Foundation Linux Platform: Linux multiple modules Flag: An issue whose reproduction requires multiple modules name lookup Area → compiler → type checker: Name lookup source compatibility suite Flag: An issue that surfaced in the source compatibility suite swift 6.0 type checker Area → compiler: Semantic analysis type declarations Feature → declarations: Type declarations unexpected error Bug: Unexpected error
Projects
None yet
Milestone
No milestone
3 participants
@eeckstein @gregomni @AnthonyLatsis