Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bundle.module paths #4573

Open
MaxDesiatov opened this issue May 19, 2022 · 2 comments
Open

Fix Bundle.module paths #4573

MaxDesiatov opened this issue May 19, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@MaxDesiatov
Copy link

Currently use of Bundle.module for static resources causes issues, check the URL generated by carton with SwiftWasm 5.6 in this code: https://github.com/swiftwasm/carton/blob/b9dab08e869f51415a55b3bb15a3e29cfd1e16e7/Tests/Fixtures/TestApp/Sources/TestApp/main.swift#L48

It contains full path to the toolchain, which is obviously invalid.
@MaxDesiatov MaxDesiatov added the bug Something isn't working label May 19, 2022
@kateinoigakukun
Copy link
Member

FWIW I think the full path was embedded by SwiftPM code generator for Bundle.module

@filip-sakel
Copy link

It seems that SwiftPM generates the bundle path here (by appending the bundle extension to the build path), then this property conditionally exposes the bundle path, and finally —on the WASI platform— the entire absolute path is retained, leading to the issue described.

@kateinoigakukun kateinoigakukun moved this to To triage in Yuta's project Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Yuta's project
Status: To triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MaxDesiatov @kateinoigakukun @filip-sakel