Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component]: Interactive Card #4322

Open
5 of 14 tasks
gfellerph opened this issue Dec 17, 2024 · 5 comments
Open
5 of 14 tasks

[component]: Interactive Card #4322

gfellerph opened this issue Dec 17, 2024 · 5 comments
Assignees
Labels
📦 styles Related to the @swisspost/design-system-styles package
Milestone

Comments

@gfellerph
Copy link
Member

gfellerph commented Dec 17, 2024

Description

Create styles for an interactive card component.

Design

Tokens

  • Tokens for this component are ready

Tasks design

🎨 Design

Preview Give feedback

Development Requirements

  • The whole card area is clickable and interactive (hover, focus), but elements on the card can be interacted with and all aria roles are semantically exposed (card is not wrapped inside a button or a link). Text can be selected (no invisible element is laid over the card). Use [component]: Link area #3830 for this purpose
  • Text and background color of the card change on hover. Ideally text color needs to only be overwritten on card level and gets inherited by all content elements
  • Card background should stand out from the section background. Cards on white should be light grey and cards on grey backgrounds should be white. Use palette classes to set card backgrounds, add colours for hover manually.

Token list

  • Background & foreground hover default
  • Background & foreground hover alternate
  • Background & foreground hover accent
  • Background & foreground hover brand
  • Shadow default & hover
  • Border radius
  • Card body padding (padding inline/block for the content block)

Notes:

  • Focus is the same as for all other elements
  • Spacing between content elements should be the default, not specified on the card

Tasks development

💻 Development

Preview Give feedback
@gfellerph gfellerph added 💭 draft Issue is not ready for development 📦 styles Related to the @swisspost/design-system-styles package labels Dec 17, 2024
@gfellerph gfellerph removed the 💭 draft Issue is not ready for development label Dec 18, 2024
@gfellerph gfellerph added this to the PPNL Support milestone Dec 18, 2024
@sandra-post
Copy link

@rouvenpost Ready for your review :-)

@sandra-post sandra-post moved this from 👀 Triage to 🎨 Ready for designer review in Design System Production Board Dec 18, 2024
@rouvenpost
Copy link

  • Responsive behavoiur (mobile Viewports) is missing
  • Negative Variants are missing
  • Custom Content should be removed

@sandra-post
Copy link

sandra-post commented Dec 19, 2024

After review with @rouvenpost following status:

  • Removed component ❖ _Card interactive in Card Foundations, but kept documentation to serve as basis guideline for any interactive card we create in DS
  • Additional to the component ❖ Teaser card , I will create today the component ❖ Teaser module with all the different color variations which are allowed.

➡️ @gfellerph The design for the ❖ Teaser card itself is ready for dev. Is there anything else I need to adjust from your POV?

@sandra-post sandra-post moved this from 🎨 Ready for designer review to 🎨 Design in progress in Design System Production Board Dec 19, 2024
@sandra-post
Copy link

Component ❖ Teaser section is now also finalized.
@rouvenpost Ready for documentation review.

@sandra-post sandra-post moved this from 🎨 Design in progress to 🎨 Design docs in review in Design System Production Board Dec 20, 2024
@gfellerph gfellerph assigned alizedebray and unassigned gfellerph Dec 20, 2024
@gfellerph
Copy link
Member Author

@alizedebray this needs a design review from development and maybe a refinement of the tokens proposal. It would be good to prioritise this component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Status: 🎨 Design docs in review
Development

No branches or pull requests

4 participants