Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vulnerability] All versions of package merge are vulnerable to Prototype Pollution via _recursiveMerge #40

Open
ekelvin opened this issue Mar 4, 2021 · 3 comments

Comments

@ekelvin
Copy link

ekelvin commented Mar 4, 2021

In absence of a security policy I am creating the issue here.
CVE-2020-28499
https://nvd.nist.gov/vuln/detail/CVE-2020-28499#match-6281551

@matheo
Copy link

matheo commented May 21, 2021

@ekelvin what does the library need to avoid Prototype Pollution completely? this?:

- if (key === '__proto__' || key === 'constructor' || key === 'prototype')
+ if (key === '__proto__' || key === 'constructor' || key === 'prototype' || key === 'toString' || key === 'hasOwnProperty')

@samydavd
Copy link

samydavd commented Apr 3, 2023

Hi @matheo, can you publish your repository in npm registry?

Otherwise, there is this other vulnerability: CVE-2021-23397 (https://nvd.nist.gov/vuln/detail/CVE-2021-23397).

Although I know this vulnerability is about another library but that came up running the dependency check over this merge library!

I don't know if this fix solves the problem

@juanrgm
Copy link
Member

juanrgm commented May 5, 2023

The CVE (GHSA-7wpw-2hjm-89gp) says:

  • Affected versions < 2.1.1
  • Patched versions 2.1.1

What is the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants