Skip to content
This repository has been archived by the owner on Jun 14, 2019. It is now read-only.

Toast notification for uploading extension shows ID #432

Open
gashcrumb opened this issue Jun 6, 2019 · 2 comments
Open

Toast notification for uploading extension shows ID #432

gashcrumb opened this issue Jun 6, 2019 · 2 comments
Assignees
@elvisisking
Labels
notif/triage

Comments

@gashcrumb
Copy link
Collaborator

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

It should show the extension name field instead or if that isn't set (I don't know why that would be) then extensionId field as a secondary. Right now it's showing id:

image
@pure-bot pure-bot bot added the notif/triage label Jun 6, 2019
@elvisisking
Copy link
Contributor

I did fix this in #419. I can move that code over.

@elvisisking elvisisking self-assigned this Jun 6, 2019
@gashcrumb
Copy link
Collaborator Author

Oh okay! Either way, if you've not much else on that refactor it'd probably be better to just finish that work up and call it the fix for this issue 😄

@elvisisking elvisisking mentioned this issue Jun 20, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@elvisisking elvisisking

Labels
notif/triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gashcrumb @elvisisking