Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Problem about GetRegion #345

Open
Tangruilin opened this issue Dec 10, 2021 · 2 comments
Open

The Problem about GetRegion #345

Tangruilin opened this issue Dec 10, 2021 · 2 comments

Comments

@Tangruilin
Copy link

In lab3b, we meet a confusing problem. In TestSplitConfChangeSnapshotUnreliableRecoverConcurrentPartition3B, we will sometimes meet no region. There is such a case, the oldRegion is splitted, but the newRgion now doesn't have a Leader, then the PD won't know the info of newRegion. If a getRegion msg is sent at that time, it may reply no region. The sleep time of your code is 20ms, but many students' computer may not perform well enough.
@Tangruilin
Copy link
Author

We change the sleep time to 50ms then it does not appear now, but I think you may let PD know the region while starting it but not the heartbeat.

@Connor1996
Copy link
Collaborator

Connor1996 commented Dec 13, 2021 •
edited
Loading

"let PD know the region while starting it but not the heartbeat" that's what your impl should consider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Connor1996 @Tangruilin