Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize CallError::what_ #4

Open
taminob opened this issue Mar 20, 2024 · 0 comments
Open

Optimize CallError::what_ #4

taminob opened this issue Mar 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@taminob
Copy link
Owner

taminob commented Mar 20, 2024 •
edited
Loading

Currently, an error contains a simple std::string which can lead to unnecessary overhead due to string copying.
Since many error strings are constant, it might be sufficient to store a pointer to some constant memory.

Further testing and benchmarking required.
Also some additional investigation if the non-constant strings are actually necessary.
@taminob taminob added the enhancement New feature or request label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taminob