Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie Destruction #106

Open
G3n3ralTao opened this issue Dec 20, 2013 · 1 comment
Open

Movie Destruction #106

G3n3ralTao opened this issue Dec 20, 2013 · 1 comment

Comments

@G3n3ralTao
Copy link

While doing some optimisation in our latest project using Flump, we found that the Layer instance in the Movie are not cleared when we destroy it. Result: We end up with a gain of 15k of KeyFrameMold instance in the profiler.

I added manually a destroy function that clean all the layers in the Vector of Movie and all the KeyFrameMold in the Vector of Layer and everything went down to zero.

@tconkling
Copy link
Owner

Hi GeneralTao - sorry for not replying earlier and thanks for filing the issue.

When you say that the Layers are not "cleared out", are you saying that there's a memory leak, or that explicitly nulling out the layers causes them to be garbage collected more quickly?

Either way, feel free to file a pull request with your changes and I'll take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants