Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprites with size larger than 2046px break preview mode #144

Open
mathieuanthoine opened this issue Dec 27, 2015 · 6 comments
Open

Sprites with size larger than 2046px break preview mode #144

mathieuanthoine opened this issue Dec 27, 2015 · 6 comments

Comments

@mathieuanthoine
Copy link

Hi,

If a FLA created for Flump has a Sprite with a width or height larger than 2046 pixels, the preview mode is broken (lists of Movie and Texture are empty).
Show Atlas and export seem to work correctly.

@markknol
Copy link

While this is probably a bug, I still would suggest to break such big sprites into pieces. This leads to better performance on mobile devices.

@mathieuanthoine
Copy link
Author

Even if it's better for mobile to have smaller sprite sheets, it's still a bug :)

PS: If you set a restriction on size, it could be better to set to 2048 and not 2046 :). It could be used for Desktop games :)

@tconkling
Copy link
Owner

I'm guessing the reason it breaks at > 2046 (rather than 2048) is because we add a 2px padding to textures by default. And we don't currently properly support 4K texture atlases, which your > 2046 texture is necessitating. This has been on my TODO list for a while but I've been neglecting Flump while I try to ship my game :)

@mathieuanthoine
Copy link
Author

thank you for the explanations, it's clearer now :)
If you need help to fix the bug, don't hesitate.

@tconkling
Copy link
Owner

Oh, I'm always happy for help fixing bugs! Please do look into it if you're
able. I can help point you in the right direction - it's just that my Flump
dev time is pretty limited these days.

On Sat, Jan 2, 2016 at 4:56 PM, mathieuanthoine [email protected]
wrote:

thank you for the explanations, it's clearer now :)
If you need help to fix the bug, don't hesitate.


Reply to this email directly or view it on GitHub
#144 (comment).

@mathieuanthoine
Copy link
Author

I can help point you in the right direction
Please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants