Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): simplified the auth guard logic to match compass goals #12

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(core): simplified the auth guard logic to match compass goals #12

wants to merge 1 commit into from

Conversation

audsostrom
Copy link
Member

Just transferring over the auth guard changes from compass goals and updating them here as well.

@audsostrom audsostrom linked an issue Aug 9, 2024 that may be closed by this pull request
Simplify auth guard logic #11
Open
jasminetai
jasminetai requested changes Aug 9, 2024
View reviewed changes
Copy link

@jasminetai jasminetai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comment, and fix the linting error, but this looks fine otherwise!

src/app/core/auth/auth.guard.ts
}

// After this point user must be logged in
if ((state.url === '/' || state.url === '/landing')) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you accidentally duplicated this block from the one right above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasminetai jasminetai jasminetai requested changes

@davidtlee davidtlee Awaiting requested review from davidtlee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify auth guard logic
2 participants
@audsostrom @jasminetai