Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native sidecars feature doesn't work on AWS EKS #8446

Open
say5 opened this issue Dec 18, 2024 · 0 comments · May be fixed by #8447
Open

Native sidecars feature doesn't work on AWS EKS #8446

say5 opened this issue Dec 18, 2024 · 0 comments · May be fixed by #8447
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@say5
Copy link

say5 commented Dec 18, 2024

Expected Behavior

Feature-flag enable-kubernetes-sidecar: "true" should enable native sidecar feature on k8s versions 1.29+

Actual Behavior

On AWS EKS cluster running version 1.30 enabling this flag doesn't affect pipeline controller.

Steps to Reproduce the Problem

  1. Enable flag on pipeline controller running on EKS cluster
  2. Check if it works

Additional Info

  • Kubernetes version:
Server Version: v1.30.6-eks-7f9249a
  • Tekton Pipeline version:
v0.65.2

The problem is here and here

svMinorInt, _ := strconv.Atoi(sv.Minor)

In our case sv.Minor string has value 30+ and as a result svMinorInt has value 0. According to this + is expected.
@say5 say5 added the kind/bug Categorizes issue or PR as related to a bug. label Dec 18, 2024
@say5 say5 changed the title Native sidecars feature doesn't work on EKS. Native sidecars feature doesn't work on AWS EKS Dec 18, 2024
@say5 say5 linked a pull request Dec 18, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: minor version check for sidecar logic say5/pipeline
1 participant
@say5