From 4c2347ad72168bf13b0ae38dfcbb341d3cb616ec Mon Sep 17 00:00:00 2001 From: Carly de Frondeville Date: Thu, 14 Nov 2024 11:19:51 -0800 Subject: [PATCH 1/2] add VersioningBehaviorOverride to StartWorkflowExecutionRequest --- temporal/api/common/v1/message.proto | 2 +- temporal/api/workflow/v1/message.proto | 2 +- temporal/api/workflowservice/v1/request_response.proto | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/temporal/api/common/v1/message.proto b/temporal/api/common/v1/message.proto index 888b8eae..165941c6 100644 --- a/temporal/api/common/v1/message.proto +++ b/temporal/api/common/v1/message.proto @@ -159,7 +159,7 @@ message WorkerVersionCapabilities { // Used in both UpdateWorkflowExecutionOptions and StartWorkflowExecution to override // the versioning behavior of a specific workflow execution. If set, takes precedence -// over the sdk-sent Versioning Behavior for the specific Workflow Execution it is set on. +// over the Versioning Behavior sent by the SDK on Workflow Task completion. // To remove the override, call UpdateWorkflowExecutionOptions with a null VersioningBehaviorOverride, // and use the FieldMask to indicate that it should be mutated. message VersioningBehaviorOverride { diff --git a/temporal/api/workflow/v1/message.proto b/temporal/api/workflow/v1/message.proto index 56838aa3..215c51ac 100644 --- a/temporal/api/workflow/v1/message.proto +++ b/temporal/api/workflow/v1/message.proto @@ -363,6 +363,6 @@ message NexusOperationCancellationInfo { } message WorkflowExecutionOptions { - // If set, takes precedence over the sdk-sent Versioning Behavior for the specific Workflow Execution it is set on. + // If set, takes precedence over the Versioning Behavior sent by the SDK on Workflow Task completion. temporal.api.common.v1.VersioningBehaviorOverride versioning_behavior_override = 1; } \ No newline at end of file diff --git a/temporal/api/workflowservice/v1/request_response.proto b/temporal/api/workflowservice/v1/request_response.proto index 7f3c4b34..f25bf86b 100644 --- a/temporal/api/workflowservice/v1/request_response.proto +++ b/temporal/api/workflowservice/v1/request_response.proto @@ -201,6 +201,9 @@ message StartWorkflowExecutionRequest { temporal.api.sdk.v1.UserMetadata user_metadata = 23; // Links to be associated with the workflow. repeated temporal.api.common.v1.Link links = 24; + // If set, takes precedence over the Versioning Behavior sent by the SDK on Workflow Task completion. + // To unset the override after the workflow is running, use UpdateWorkflowExecutionOptions. + temporal.api.common.v1.VersioningBehaviorOverride versioning_behavior_override = 25; } message StartWorkflowExecutionResponse { From cfa1fbd1ba36b75485cb6a3d6b6acbe241e269c6 Mon Sep 17 00:00:00 2001 From: Carly de Frondeville Date: Thu, 14 Nov 2024 11:43:56 -0800 Subject: [PATCH 2/2] add VersioningBehaviorOverride to schedules and signal with start --- temporal/api/workflow/v1/message.proto | 3 +++ temporal/api/workflowservice/v1/request_response.proto | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/temporal/api/workflow/v1/message.proto b/temporal/api/workflow/v1/message.proto index 215c51ac..6b6ba95a 100644 --- a/temporal/api/workflow/v1/message.proto +++ b/temporal/api/workflow/v1/message.proto @@ -268,6 +268,9 @@ message NewWorkflowExecutionInfo { // for use by user interfaces to display the fixed as-of-start summary and details of the // workflow. temporal.api.sdk.v1.UserMetadata user_metadata = 14; + // If set, takes precedence over the Versioning Behavior sent by the SDK on Workflow Task completion. + // To unset the override after the workflow is running, use UpdateWorkflowExecutionOptions. + temporal.api.common.v1.VersioningBehaviorOverride versioning_behavior_override = 15; } // CallbackInfo contains the state of an attached workflow callback. diff --git a/temporal/api/workflowservice/v1/request_response.proto b/temporal/api/workflowservice/v1/request_response.proto index f25bf86b..14bc74ee 100644 --- a/temporal/api/workflowservice/v1/request_response.proto +++ b/temporal/api/workflowservice/v1/request_response.proto @@ -713,9 +713,11 @@ message SignalWithStartWorkflowExecutionRequest { // for use by user interfaces to display the fixed as-of-start summary and details of the // workflow. temporal.api.sdk.v1.UserMetadata user_metadata = 23; - // Links to be associated with the WorkflowExecutionStarted and WorkflowExecutionSignaled events. repeated temporal.api.common.v1.Link links = 24; + // If set, takes precedence over the Versioning Behavior sent by the SDK on Workflow Task completion. + // To unset the override after the workflow is running, use UpdateWorkflowExecutionOptions. + temporal.api.common.v1.VersioningBehaviorOverride versioning_behavior_override = 25; } message SignalWithStartWorkflowExecutionResponse {