Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WordSeg] Use Character instead of String in Alphabet #600

Open
texasmichelle opened this issue Jun 10, 2020 · 0 comments
Open

[WordSeg] Use Character instead of String in Alphabet #600

texasmichelle opened this issue Jun 10, 2020 · 0 comments

Comments

@texasmichelle
Copy link
Member

Currently, Alphabet's dictionary maps from String rather than Character to support tokens of length > 1 character. Using Character instead of String would work if we used special Unicode characters or enums instead of "</s>", "</w>", and "<pad>".

Since this is used in so many places in the WordSeg model, it is potentially worthwhile to make it more efficient.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@texasmichelle