Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cloud shape innerBox selection #1735

Closed
gavin-ts opened this issue Nov 16, 2023 · 0 comments · Fixed by #1736
Closed

fix cloud shape innerBox selection #1735

gavin-ts opened this issue Nov 16, 2023 · 0 comments · Fixed by #1736
Labels
bug Something isn't working

Comments

@gavin-ts
Copy link
Contributor

it looks like the cloud shape may sometimes return the incorrect innerBox it is using due to the difference in aspect ratio between the whole cloud and its innerBox.

https://github.com/terrastruct/d2/blob/master/lib/shape/shape_cloud.go#L46
@gavin-ts gavin-ts added the bug Something isn't working label Nov 16, 2023
@cyborg-ts cyborg-ts added this to D2 Nov 16, 2023
This was referenced Nov 16, 2023
Merged
Merged
@github-project-automation github-project-automation bot moved this to Done in D2 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
D2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cloud innerbox gavin-ts/d2
1 participant
@gavin-ts