Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration May Contain Secrets #32

Open
joelbixbyrevel opened this issue Jan 2, 2024 · 1 comment
Open

Configuration May Contain Secrets #32

joelbixbyrevel opened this issue Jan 2, 2024 · 1 comment

Comments

@joelbixbyrevel
Copy link

Issue

For those using SASL authentication Kafka, current configuration file may contain authentication secrets.

  "kafka": { //librdkafka kafka config, seen here: https://raw.githubusercontent.com/confluentinc/librdkafka/master/CONFIGURATION.md
    "bootstrap.servers": "kafka:9092",
    "queue.buffering.max.messages": 1000000,
    "sasl.username":  "MyUsername",
    "sasl.password": "MyPassword"
  },

Expectation

SASL credentials have a place in secure storage.

@joelbixbyrevel
Copy link
Author

Not seeing any clear workarounds for this one. I could see this being solved by moving configuration to the secrets template. Otherwise maybe some coordination required between fleet-telemtery codebase to support credentials outside of this configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant