-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing 4.9 prefs strings #313
Comments
re: Considerations:
@Bloke @bloatware - any preference? |
It's a diag error message, not sure it fits here. The trailing slash pref in question decides whether all/none/lists only links should have a trailing slash. |
@petecooper @bloatware @Bloke please either add any 4.9 string requests here or (even better) add them into |
If someone can run the string checker in the toobelt repo, that should hopefully highlight any we've missed. Bearing in mind it's not foolproof. Edit: wait, it's not there. Hmmm. I swear we had a tool to do that somewhere which romps through the core files looking for Edit 2: no wait, here it is in the Textpack repo: https://github.com/textpattern/textpacks/blob/main/tools/check-textpack.php |
I'll take dibs on the checker - likely this evening as I've got a full diary until then. Watch this space. Edit: I'm getting errors thrown on PHP 8.3 (macOS Homebrew) so I'll hook this into the demo server so we can automate it. |
OK, now automated as part of the https://dev-demo.textpattern.co/dev/missing.txt Needs some tweaks, I think - there seems to be a lot in there. |
Oooh nice one. Bear in mind that many of these strings might be from deprecated functions (e.g. account_activation_*) so we don't need to bother about them. Not sure how to exclude those. Ideas welcome. |
Hi, I'm back from holiday now. What Strings do I need to add? So far I can tell only one?...
Which I will add now. But what group does it go in (I've put in |
|
We don't distinguish, as far as I recall. |
trailing_slash
(Site) – added via ef8af38 hat tip @rwetzlmayrfile_download_header
(Advanced Options)The text was updated successfully, but these errors were encountered: