Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Typescript for better type checking #11

Open
qaz74107410 opened this issue Feb 13, 2021 · 1 comment
Open

Using Typescript for better type checking #11

qaz74107410 opened this issue Feb 13, 2021 · 1 comment

Comments

@qaz74107410
Copy link

I would suggest to refactor to Typescript instead of Javascript. No more if(!Number(amount)){ return false }

Anyway, The plus is everyone could know what type of parameter can they put through the function, etc. which is really good for new contributors.
@thananon
Copy link
Owner

Yeah, good suggestion. Only thing is I dont know anything about TS. It seems people really wants to go for it. Good. Please open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qaz74107410 @thananon