Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: require CSS selector #690

Open
Kat-Alo opened this issue Sep 8, 2023 · 1 comment
Open

Feature request: require CSS selector #690

Kat-Alo opened this issue Sep 8, 2023 · 1 comment

Comments

@Kat-Alo
Copy link

Kat-Alo commented Sep 8, 2023

It seems that leaving the Selector field blank renders a watched page un-watchable (Please correct me if this is wrong.). We've tried communicating with our users that they must populate that field with a selector, but it would be a nice lil feature to force that field to be populated in order to save the page; especially because failure to detect changes happens quietly (that is, users will likely just be unaware that their watched page isn't working the way they thought it would).

Relatedly, I think the site URL is also an optional field. While it's more obvious that the page watch should fail, I think it might be nice to have it be a required field as well.

@rdmurphy
Copy link
Contributor

Huh — that is baffling. I'm trying really hard to think of a reason why either of those fields are not currently required and were not in the first place. 😅 I guess I could see a scenario where no css_selector means "watch this entire page" but as you noted we aren't actually doing that currently so it'd be hard to argue that's currently the expectation. Same with url too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants