[HD-A] System does not wake up Playback/Capture-> pause -> suspend->resume scenario

[ssavati]

System is not waking up Playback/Capture-> pause -> resume scenario.

Steps to reproduce

• Use Any HDA board (I have tried MTLP and ADLP Platforms)
• Open a terminal and execute cmd aplay -Dhw:0,0 -fs16_le -c2 -r 48000 -vv -i /dev/zero
• Press space to pause
• Open another terminal and perform sudo rtcwake -m mem -s 10
• sudo rtcwake -m mem -s 10
• At this stage system not comeback and need reboot

Other observation

For SDW configuartion issue not observed.
This issue is observed for Headset playback/capture. for HDMI device system wakes up.
System wake up if we do suspend without pausing Playback/capture.

Issue reproduciblity : 100%

Kernel/firmware branch/commits
Linux Branch:
topic/sof-dev
Linux Commit:
fbf0b7bd4110

SOF Branch:
main
SOF Commit:
283475c0d6c8
Zephyr Commit:
9d8059b6e554

cc:

• [LNL]Suspend resume with playback or capture will Fail or TIMEOUT #5080

[plbossart]

Thanks for testing this @ssavati, this looks like a global issue indeed. Could you test this on LNL where the HDAudio DMA is used as well, I am not sure we're tested this, ever.

@kv2019i @ranj063 @ujfalusi my money is on a transition where we keep the DMA programmed, which is known to have side effects.

[ujfalusi]

I can confirm this on TGL (upx-i11)

[ujfalusi]

I think I have a fix for this...

[ujfalusi]

I think I have a fix for this...

it will take some time. I can prevent the lockup, but the sequencing is pretty broken.

[ujfalusi]

The finding so far:
suspend while pause does not work (locks up the system) with sof-dev with IPC3 and IPC4 alike
The lockup is caused by incorrect code in hda_dai_suspend()
Fixing the function will allow the suspend/resume while paused, but it is still broken for IPC3/IPC4:
IPC3 is w/o errors but when you try to un-pause, the aplay will exit
IPC4 have IPC errors on suspend, but after resume we manage to restart the stream (resume fail, and full restart happens)

To fix the IPC4 errors and the broken IPC3 we need to move the paused stream to suspend-proper by:

int sof_pcm_suspend_paused(struct snd_sof_dev *sdev)
{
	struct snd_pcm_substream *substream;
	struct snd_sof_pcm *spcm;
	int dir, ret;

	list_for_each_entry(spcm, &sdev->pcm_list, list) {
		for_each_pcm_streams(dir) {
			substream = spcm->stream[dir].substream;
			if (!substream || !substream->runtime)
				continue;

			if (!(substream->runtime->state == SNDRV_PCM_STATE_SUSPENDED &&
			    substream->runtime->suspended_state == SNDRV_PCM_STATE_PAUSED))
				continue;

			ret = substream->ops->trigger(substream,
						      SNDRV_PCM_TRIGGER_PAUSE_RELEASE);
			if (ret)
				return ret;

			ret = substream->ops->trigger(substream,
						      SNDRV_PCM_TRIGGER_SUSPEND);
			if (ret)
				return ret;
		}
	}

	return 0;
}

and call this from early suspend.
This will make the errors go away, but still a full restart will be done instead of a clean resume...

[plbossart]

we had to do something manually for SoundWire to support the suspend-while-paused transition.

static int intel_component_dais_suspend(struct snd_soc_component *component)
{
	struct snd_soc_dai *dai;

	/*
	 * In the corner case where a SUSPEND happens during a PAUSE, the ALSA core
	 * does not throw the TRIGGER_SUSPEND. This leaves the DAIs in an unbalanced state.
	 * Since the component suspend is called last, we can trap this corner case
	 * and force the DAIs to release their resources.
	 */
	for_each_component_dais(component, dai) {
		struct sdw_cdns *cdns = snd_soc_dai_get_drvdata(dai);
		struct sdw_cdns_dai_runtime *dai_runtime;

		dai_runtime = cdns->dai_runtime_array[dai->id];

		if (!dai_runtime)
			continue;

		if (dai_runtime->suspended)
			continue;

		if (dai_runtime->paused)
			dai_runtime->suspended = true;
	}

	return 0;
}

[ujfalusi]

I can confirm this on TGL (upx-i11)

It happens with both IPC3 and IPC4.

[ujfalusi]

Strictly avoiding the lockup: #5049
Suspend while paused remains broken, but at least the system is not locked and we got to see the nice IPC and other errors and application giving up (aplay)

[marc-hb]

I haven't followed what changed exactly but in the last 4 years I've never seen a suspend/resume pass rate so high than in the last week or two. I mean across the board, not with LNL specifically.