From bb195f4b2c55d85b71d4e4565913230723f09155 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Dalfors?= Date: Mon, 17 Jun 2024 11:39:29 +0200 Subject: [PATCH] Make workflow run workflow in source repo context to prevent secrets exposure. Remove file upload since it no longer has access to secrets --- .github/workflows/tests.yml | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 5b842345..eb381615 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -1,5 +1,5 @@ on: - pull_request_target: # Use pull_request_target + pull_request: branches: [master, beta, release] jobs: @@ -22,17 +22,3 @@ jobs: run: yarn ui-test - name: Post-processing run: ./scripts/prepareVideo.sh - - uses: hkusu/s3-upload-action@v2 - id: upload # specify some ID for use in subsequent steps - with: - aws-access-key-id: ${{ vars.AWS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-region: 'eu-central-1' - aws-bucket: ${{ vars.AWS_BUCKET }} - file-path: './ui-test.gif' - content-type: image/gif - output-file-url: 'true' - - name: Show URL - run: echo '${{ steps.upload.outputs.file-url }}' - id: artifact-upload-step - - run: echo '' >> $GITHUB_STEP_SUMMARY