Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate when a community is locked #1022

Closed
K4LCIFER opened this issue Jan 6, 2024 · 8 comments
Closed

Indicate when a community is locked #1022

K4LCIFER opened this issue Jan 6, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version

Comments

@K4LCIFER
Copy link
Contributor

K4LCIFER commented Jan 6, 2024

Is your feature request related to a problem? Please describe.
Currently there is no visual indication that a community is locked beyond simply lacking the button to make a post.

Describe the solution you'd like
I think it would be good to have a visual indicator that a community is locked -- similar to that of a post when it is locked. A simple padlock, or text saying "community locked to collaboration" or something would suffice.

Describe alternatives you've considered
None.

Additional context
An example is [email protected]. The comumnity is locked to posts other than mods, but there is no visual indication that it is locked other than you don't have the button to create a post.

@K4LCIFER K4LCIFER added the enhancement New feature or request label Jan 6, 2024
@hjiangsu
Copy link
Member

hjiangsu commented Jan 8, 2024

Thanks for the feature request! One way to show this information is to place it in the community header when navigating to a community. Do you think something like this will suffice? There is an initial PR for this with more screenshots if you're curious.

@micahmo I'd like to get your thoughts as well!

IMG_1564

@hjiangsu hjiangsu self-assigned this Jan 8, 2024
@hjiangsu hjiangsu added the in-progress Indicates that an issue is currently being worked on label Jan 8, 2024
@K4LCIFER
Copy link
Contributor Author

K4LCIFER commented Jan 8, 2024

I like the look of that lock icon! I am somewhat concerned, however, that, if the lock icon is placed within the logo, it could be accidentally mistaken as part of the logo. Perhaps it would be better to give it a more isolated spot on the community header bar?

@hjiangsu
Copy link
Member

hjiangsu commented Jan 8, 2024

Do you think it would be better suited to be part of the statistics portion of the header? (e.g., beside the number of posts)

image

@K4LCIFER
Copy link
Contributor Author

K4LCIFER commented Jan 9, 2024

Yeah, perhaps to the right of the calendar icon would be a good spot for it? Unfortunately, I don't have a whole lot of experience in UI design, so I'm not sure how much my opinion is worth.

I think it could still be possible to keep the lock on the community logo, as you originally had, just so long as long as it's possible to make it obvious that the lock itself isn't a part of the logo.

@micahmo
Copy link
Member

micahmo commented Jan 9, 2024

I like this feature, and I am fine with the implementation as part of the community icon. Since it cuts into the logo, I think it's obviously not part of it. But I also wouldn't mind if it's part of the stats area.

P.S. There's another change that I think would be nice here. When a post is locked, we change the reply button to a lock icon, and when pressed, we show a snackbar indicating that the post is locked. It might be nice to apply the same treatment to the new post button in locked communities!

@K4LCIFER
Copy link
Contributor Author

K4LCIFER commented Jan 9, 2024

When a post is locked, we change the reply button to a lock icon, and when pressed, we show a snackbar indicating that the post is locked.

I completely agree!

@hjiangsu
Copy link
Member

Sorry it took me so long to get back to this! I added some initial moderating related features in #1063 which allowed me to work on getting the lock on the FAB.

This is the final result that I have. I've opted to keep the lock icon as part of the community, and added the lock status to the FAB to indicate that posting is restricted. Any further thoughts?

simulator_screenshot_633DA583-6659-4F6A-A6DC-9F4FDBF6EB5F simulator_screenshot_3EFEADC6-8D30-4FCF-9C0C-63EB35F767F6

@micahmo
Copy link
Member

micahmo commented Jan 30, 2024

I think it looks great!

@hjiangsu hjiangsu added fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version and removed in-progress Indicates that an issue is currently being worked on labels Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

3 participants