Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated prefixes #334

Open
oliviertassinari opened this issue Aug 30, 2024 · 2 comments
Open

Remove outdated prefixes #334

oliviertassinari opened this issue Aug 30, 2024 · 2 comments

Comments

@oliviertassinari
Copy link

Stylis includes a prefixer module:

import { prefixer } from 'stylis';

This is very helpful as there are CSS properties that need vendor prefixes. For example, user-select: none; still requires it in browsers that have an important global usage rate.

However, I have noticed a couple of prefixes that I would argue are more harmful than beneficial. Mainly, the flexbox properties. The global need for the prefix seems to be 0.48% (0.01 + 0.14 + 0.05 + 0.01 + 0.02 + 0.03 + 0.01 + 0.1 + 0.11). Do we need to keep it, at this point?

By removing it, we would gain:

  1. A better DX when debugging CSS. When this module is used with emotion, you get this kind of output by default

Before

Screenshot 2022-01-22 at 19 31 18

After is so much better:

Screenshot 2022-01-22 at 19 31 30

  1. A smaller bundle.

Actually, this might simply be the root cause of a different problem: What's the browser support target? Do we have something like this https://github.com/kripod/style-vendorizer#browser-support?


@petr001
Copy link

petr001 commented Dec 4, 2024

yeah, prefixes are dead, let's have them optional pls

@oliviertassinari
Copy link
Author

cc @brijeshb42 adding this in your radar. It fits well under the "improving the style engine of MUI" north start objective of your team (so far 1 person but hopefully we can grow this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants